Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(helm): Refactoring Kubernetes recommended labels #777

Merged
merged 6 commits into from
May 8, 2024
Merged

feat(helm): Refactoring Kubernetes recommended labels #777

merged 6 commits into from
May 8, 2024

Conversation

nlamirault
Copy link
Contributor

PR Description

Support all Kubernetes recommended labels

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

rfratto
rfratto reviewed May 6, 2024
View reviewed changes
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you add this to the Helm chart's changelog as an "other change"?

Like this:

Unreleased 
----------

### Other changes 

- (Description of your change here)

@nlamirault
add changelog entry
26447f0 
Signed-off-by: Nicolas Lamirault <[email protected]>
@nlamirault
bump Helm chart version
ed1edde 
Signed-off-by: Nicolas Lamirault <[email protected]>
@nlamirault
Copy link
Contributor Author

@rfratto done. I bump the chart version also, but I'm not sure for version (minor or patch).

rfratto
rfratto approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rfratto rfratto merged commit 9348743 into grafana:main May 8, 2024
15 checks passed
@rfratto rfratto added the backport-to-agent:no PR should NOT be backported to the agent repo. label May 14, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rfratto rfratto rfratto approved these changes

Assignees
No one assigned
Labels
backport-to-agent:no PR should NOT be backported to the agent repo. frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nlamirault @rfratto